Add webhook callback url in run workflow form #1035
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…src/' <!-- ELLIPSIS_HIDDEN --> > [!IMPORTANT] > Add `webhookCallbackUrl` field to `RunWorkflowForm` with validation and UI changes in `RunWorkflowForm.tsx`. > > - **Behavior**: > - Add `webhookCallbackUrl` field to `RunWorkflowForm` in `RunWorkflowForm.tsx`. > - Update form submission to include `webhookCallbackUrl` in the request body if provided. > - **Validation**: > - Add URL validation for `webhookCallbackUrl` using `zod` schema. > - **UI**: > - Add new section "Advanced Settings" for `webhookCallbackUrl` input in the form. > > <sup>This description was created by </sup>[<img alt="Ellipsis" src="https://img.shields.io/badge/Ellipsis-blue?color=175173">](https://www.ellipsis.dev?ref=Skyvern-AI%2Fskyvern-cloud&utm_source=github&utm_medium=referral)<sup> for 33008e62a3f1d4d5da1a31d4906b4301d0f8ba4c. It will automatically update as commits are pushed.</sup> <!-- ELLIPSIS_HIDDEN -->
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
👍 Looks good to me! Incremental review on 45e0a5f in 8 seconds
More details
- Looked at
261lines of code in1files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. skyvern-frontend/src/routes/workflows/RunWorkflowForm.tsx:216
- Draft comment:
Consider returning a message indicating that the field is optional when the value is null. - Reason this comment was not posted:
Confidence changes required:50%
The validation for the webhookCallbackUrl field is not returning a message when the value is null, which might lead to confusion for users. It should return a message indicating that the field is optional or required.
Workflow ID: wflow_P3IckHwgktT22nJJ
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
There was a problem hiding this comment.
👍 Looks good to me! Reviewed everything up to 45e0a5f in 7 seconds
More details
- Looked at
261lines of code in1files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. skyvern-frontend/src/routes/workflows/RunWorkflowForm.tsx:213
- Draft comment:
Consider using zod's built-in validation directly in the useForm hook to avoid duplicating validation logic for webhookCallbackUrl. - Reason this comment was not posted:
Confidence changes required:50%
The validation logic for the webhookCallbackUrl field is duplicated. It can be simplified by using zod's built-in validation directly in the useForm hook.
Workflow ID: wflow_7pR2JNDCRBsVTYsA
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
Add
webhookCallbackUrlfield toRunWorkflowFormwith validation and UI changes inRunWorkflowForm.tsx.webhookCallbackUrlfield toRunWorkflowForminRunWorkflowForm.tsx.webhookCallbackUrlin the request body if provided.webhookCallbackUrlusingzodschema.webhookCallbackUrlinput in the form.This description was created by
for 45e0a5f. It will automatically update as commits are pushed.